Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't round balances #2852

Merged

Conversation

artursapek
Copy link
Collaborator

IMG_7494

Copy link

netlify bot commented Oct 16, 2024

👷 Deploy request for wormhole-connect pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit b598dff

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for wormhole-connect-mainnet ready!

Name Link
🔨 Latest commit b598dff
🔍 Latest deploy log https://app.netlify.com/sites/wormhole-connect-mainnet/deploys/6710295ac3493900086f5100
😎 Deploy Preview https://deploy-preview-2852--wormhole-connect-mainnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

emreboga
emreboga previously approved these changes Oct 16, 2024
Copy link
Collaborator

@emreboga emreboga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kev1n-peters
Copy link
Collaborator

Do we want to truncate the balance that gets displayed?
image

@artursapek
Copy link
Collaborator Author

Do we want to truncate the balance that gets displayed? image

good point. I guess this "just worked" before. I'll fix this

@Wesleyleung
Copy link
Collaborator

Yeah we should truncate the balance that gets displayed too. You should be able to type in as long of a string as you want for your input, but the small gray balance display should also be truncated so that it doesn't bleed over.

@artursapek artursapek merged commit a40a8d0 into wormhole-foundation:development Oct 17, 2024
12 checks passed
@artursapek artursapek deleted the max-amt-bug branch October 17, 2024 20:05
@Wesleyleung
Copy link
Collaborator

Might have left out truncating the Network Costs too :O

Screenshot 2024-10-22 at 11 44 11 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants